tests/unit/Validator/IndexTest.php (1)

636-655: Prefer named args for Index validator construction (too many positional booleans).
This test is fragile to constructor re-ordering and hard to review.

Example refactor (adjust names to actual signature)

-        $validator = new Index(
-            $collection->getAttribute('attributes'),
-            $collection->getAttribute('indexes', []),
-            768,
-            [],
-            false, // supportForArrayIndexes
-            false, // supportForSpatialIndexNull
-            false, // supportForSpatialIndexOrder
-            false, // supportForVectorIndexes
-            true,  // supportForAttributes
-            true,  // supportForMultipleFulltextIndexes
-            true,  // supportForIdenticalIndexes
-            false, // supportForObjectIndexes
-            false, // supportForTrigramIndexes
-            false, // supportForSpatialIndexes
-            true,  // supportForKeyIndexes
-            true,  // supportForUniqueIndexes
-            true,  // supportForFulltextIndexes
-            true   // supportForTTLIndexes
-        );
+        $validator = new Index(
+            attributes: $collection->getAttribute('attributes'),
+            indexes: $collection->getAttribute('indexes', []),
+            maxLength: 768,
+            reservedKeys: [],
+            supportForArrayIndexes: false,
+            supportForSpatialIndexNull: false,
+            supportForSpatialIndexOrder: false,
+            supportForVectorIndexes: false,
+            supportForAttributes: true,
+            supportForMultipleFulltextIndexes: true,
+            supportForIdenticalIndexes: true,
+            supportForObjectIndexes: false,
+            supportForTrigramIndexes: false,
+            supportForSpatialIndexes: false,
+            supportForKeyIndexes: true,
+            supportForUniqueIndexes: true,
+            supportForFulltextIndexes: true,
+            supportForTTLIndexes: true,
+        );

tests/e2e/Adapter/Scopes/DocumentTests.php (2)

7431-7543: Make testTTLIndexes deterministic (auth state, datetime filter, and cleanup).

This test currently relies on ambient Authorization state and doesn’t guarantee cleanup if an assertion fails; also the expiresAt attribute is created without an explicit datetime filter (but later you do include it via the attribute Document).

Proposed hardening diff

 public function testTTLIndexes(): void
 {
     /** @var Database $database */
     $database = static::getDatabase();

     if (!$database->getAdapter()->getSupportTTLIndexes()) {
         $this->expectNotToPerformAssertions();
         return;
     }

-    $col = uniqid('sl_ttl');
-    $database->createCollection($col);
-
-    $database->createAttribute($col, 'expiresAt', Database::VAR_DATETIME, 0, false);
+    Authorization::cleanRoles();
+    Authorization::setRole(Role::any()->toString());
+
+    $col = 'sl_ttl_' . ID::unique();
+    $col2 = 'sl_ttl_collection_' . ID::unique();
+
+    try {
+        $database->createCollection($col);
+
+        $database->createAttribute(
+            $col,
+            'expiresAt',
+            Database::VAR_DATETIME,
+            0,
+            false,
+            filters: ['datetime']
+        );

     $permissions = [
         Permission::read(Role::any()),
         Permission::write(Role::any()),
         Permission::update(Role::any()),
         Permission::delete(Role::any())
     ];

     $this->assertTrue(
         $database->createIndex(
             $col,
             'idx_ttl_valid',
             Database::INDEX_TTL,
             ['expiresAt'],
             [],
             [Database::ORDER_ASC],
             3600 // 1 hour TTL
         )
     );

     $collection = $database->getCollection($col);
     $indexes = $collection->getAttribute('indexes');
     $this->assertCount(1, $indexes);
     $ttlIndex = $indexes[0];
     $this->assertEquals('idx_ttl_valid', $ttlIndex->getId());
     $this->assertEquals(Database::INDEX_TTL, $ttlIndex->getAttribute('type'));
     $this->assertEquals(3600, $ttlIndex->getAttribute('ttl'));

     $now = new \DateTime();
     $future1 = (clone $now)->modify('+2 hours');
     $future2 = (clone $now)->modify('+1 hour');
     $past = (clone $now)->modify('-1 hour');

     $database->createDocuments($col, [
         new Document([
             '$id' => 'doc1',
             '$permissions' => $permissions,
             'expiresAt' => $future1->format(\DateTime::ATOM),
         ]),
         new Document([
             '$id' => 'doc2',
             '$permissions' => $permissions,
             'expiresAt' => $future2->format(\DateTime::ATOM),
         ]),
         new Document([
             '$id' => 'doc3',
             '$permissions' => $permissions,
             'expiresAt' => $past->format(\DateTime::ATOM),
         ])
     ]);

     $this->assertTrue($database->deleteIndex($col, 'idx_ttl_valid'));

     $this->assertTrue(
         $database->createIndex(
             $col,
             'idx_ttl_min',
             Database::INDEX_TTL,
             ['expiresAt'],
             [],
             [Database::ORDER_ASC],
             1 // Minimum TTL
         )
     );

-    $col2 = uniqid('sl_ttl_collection');
-
     $expiresAtAttr = new Document([
         '$id' => ID::custom('expiresAt'),
         'type' => Database::VAR_DATETIME,
         'size' => 0,
         'signed' => false,
         'required' => false,
         'default' => null,
         'array' => false,
         'filters' => ['datetime'],
     ]);

     $ttlIndexDoc = new Document([
         '$id' => ID::custom('idx_ttl_collection'),
         'type' => Database::INDEX_TTL,
         'attributes' => ['expiresAt'],
         'lengths' => [],
         'orders' => [Database::ORDER_ASC],
         'ttl' => 7200 // 2 hours
     ]);

     $database->createCollection($col2, [$expiresAtAttr], [$ttlIndexDoc]);

     $collection2 = $database->getCollection($col2);
     $indexes2 = $collection2->getAttribute('indexes');
     $this->assertCount(1, $indexes2);
     $ttlIndex2 = $indexes2[0];
     $this->assertEquals('idx_ttl_collection', $ttlIndex2->getId());
     $this->assertEquals(7200, $ttlIndex2->getAttribute('ttl'));

-    $database->deleteCollection($col);
-    $database->deleteCollection($col2);
+    } finally {
+        // Best-effort cleanup (avoid leaking collections on assertion failures)
+        try { $database->deleteCollection($col); } catch (\Throwable) {}
+        try { $database->deleteCollection($col2); } catch (\Throwable) {}
+        Authorization::cleanRoles();
+    }
 }

---

7545-7690: Reduce brittleness in duplicate-TTL assertions + ensure $col3 can’t leak on unexpected success.

The createCollection duplicate test hard-codes a very specific error message (“Index already exists”) and doesn’t clean up $col3 if the call unexpectedly succeeds (it would fail() before cleanup).

Suggested diff

-        try {
-            $database->createCollection($col3, [$expiresAtAttr], [$ttlIndex1, $ttlIndex2]);
-            $this->fail('Expected exception for duplicate TTL indexes in createCollection');
-        } catch (Exception $e) {
-            $this->assertInstanceOf(DatabaseException::class, $e);
-            // raised in the mongo level
-            $this->assertStringContainsString('Index already exists', $e->getMessage());
-        }
+        try {
+            $database->createCollection($col3, [$expiresAtAttr], [$ttlIndex1, $ttlIndex2]);
+            // If we got here, make sure we don't leak the collection before failing the test.
+            $database->deleteCollection($col3);
+            $this->fail('Expected exception for duplicate TTL indexes in createCollection');
+        } catch (DatabaseException $e) {
+            // Raised in adapter/validator layer; message may vary.
+            $this->assertStringContainsString('already', strtolower($e->getMessage()));
+        }

src/Database/Database.php (1)

1633-1658: Risky IndexValidator ctor wiring: please verify all call sites + consider named args.
Adding one more boolean at the tail is easy to mis-order across the repo; a single missed instantiation will be a runtime fatal. Also, this constructor is a prime candidate for named arguments or a small config DTO to prevent future footguns.
Based on learnings, Mongo’s getMaxIndexLength() should be non-zero (1,048,576 bytes) so the length normalization logic/validation behaves as intended.

#!/bin/bash
set -euo pipefail

echo "== IndexValidator constructor signature =="
rg -n "class\s+Index\b" src/Database/Validator/Index.php || true
rg -n "function __construct\s*\(" src/Database/Validator/Index.php || true

echo
echo "== All IndexValidator instantiations (ensure extra arg was added everywhere) =="
rg -n "new\s+IndexValidator\s*\(" src -S

echo
echo "== Adapter capability method existence =="
rg -n "function\s+getSupportTTLIndexes\s*\(" src -S

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: abnegate
Repo: utopia-php/database PR: 721
File: tests/e2e/Adapter/Scopes/AttributeTests.php:1329-1334
Timestamp: 2025-10-03T01:50:11.943Z
Learning: MongoDB has a 1024kb (1,048,576 bytes) limit for index entries. The MongoDB adapter's getMaxIndexLength() method should return this limit rather than 0.

Learnt from: abnegate
Repo: utopia-php/database PR: 721
File: tests/e2e/Adapter/Scopes/DocumentTests.php:6418-6439
Timestamp: 2025-10-03T02:04:17.803Z
Learning: In tests/e2e/Adapter/Scopes/DocumentTests::testSchemalessDocumentInvalidInteralAttributeValidation (PHP), when the adapter reports getSupportForAttributes() === false (schemaless), the test should not expect exceptions from createDocuments for “invalid” internal attributes; remove try/catch and ensure the test passes without exceptions, keeping at least one assertion.

Learnt from: fogelito
Repo: utopia-php/database PR: 733
File: src/Database/Adapter/MariaDB.php:1801-1806
Timestamp: 2025-10-16T09:37:33.531Z
Learning: In the MariaDB adapter (src/Database/Adapter/MariaDB.php), only duplicate `_uid` violations should throw `DuplicateException`. All other unique constraint violations, including `PRIMARY` key collisions on the internal `_id` field, should throw `UniqueException`. This is the intended design to distinguish between user-facing document duplicates and internal/user-defined unique constraint violations.

Learnt from: ArnabChatterjee20k
Repo: utopia-php/database PR: 747
File: src/Database/Adapter/Mongo.php:1449-1453
Timestamp: 2025-10-29T12:27:57.071Z
Learning: In src/Database/Adapter/Mongo.php, when getSupportForAttributes() returns false (schemaless mode), the updateDocument method intentionally uses a raw document without $set operator for replacement-style updates, as confirmed by the repository maintainer ArnabChatterjee20k.

Learnt from: fogelito
Repo: utopia-php/database PR: 739
File: src/Database/Adapter/Postgres.php:154-158
Timestamp: 2025-10-16T08:48:36.715Z
Learning: For the utopia-php/database repository, no migration scripts are needed for the collation change from utf8_ci to utf8_ci_ai in the Postgres adapter because there is no existing production data.